Open main menu

CDOT Wiki β

Changes

PostgreSQL Adapter Project - Code Review 4 Changes

129 bytes added, 12:18, 13 September 2011
no edit summary
|getQuotedName
* functionality is not needed just use SQLSchemamanager.quote() the way this is done in other sql manager code
|'''DONE'''
|}
*remove the condition
*it should be possible to set 0 timeout
|'''DONE'''
|-
|CancelTask -> StatementCancelationTask;
*make it a top level class
|'''DONE'''
|}
|addColumn
*change the comment to "Reads a column from a JDBC driver result set and adds it to a table object".
||-|*Move rs argument to the last position|'''DONE'''
|-
|I think the portable flag should not take into account columns that are not added to the table (return null in this case)?
|'''DONE'''
|-
| The message about ignoring an index has changed
*I think the extra info in the original message that the index was ignored was important.
|Diff is malfunctioning
|-
|There are extensive changes to readSchema?
*What is the reason for these (or is it the diff malfunctioning)?
|Diff is malfunctioning
|-
|getAlterColumnToken
*remove the separator flag.
*Adding separators should be done in different code. Each method should do as little as possible.
|'''DONE'''
|-
|isPortable()
*(Methods should not try to do several tasks at once, in this case skipping invalid entries and determining portability.
This hampers method reusability.).
|'''DONE'''
|-
| isWindowsCompatiable -> isWindowsCompatible
|'''DONE'''
|}
|*Proxy.java -> *Wrapper.java
*(this is not the proxy pattern, but more like the decorator pattern)
|'''DONE'''
|}
1
edit