Changes

Jump to: navigation, search

DPS909 & OSD600 Fall 2019

2,429 bytes added, 18:35, 10 November 2019
no edit summary
*** https://github.com/ParabolInc/action
** [https://github.com/Seneca-CDOT/telescope/issues/112 https://github.com/Seneca-CDOT/telescope/issues/112] has notes on some research into these projects. Please add more as you find it.
 
== Week 10 ==
 
* Managing change on a fast moving project with lots of people
** Documentation doesn't work, project "rules" don't work
** Communication works (Watching Issues, Slack, in person discussions) and
** You have to enforce standards across a project using tools and automation
** Continuous Integration (CI) - [https://github.com/Seneca-CDOT/telescope/issues/43 we have Travis CI enabled]
** Static Analysis Tools
*** [https://github.com/Seneca-CDOT/telescope/pull/38 we have eslint for JavaScript using the Airbnb JavaScript Style Guide]
*** [https://github.com/Seneca-CDOT/telescope/pull/125 we have stylelint for CSS]
** Automated Tests with [https://jestjs.io/docs/en/getting-started Jest]
** Next we can add Prettier for standard code formatting
 
* [https://humphd.github.io/pretty-effective/ Case Study - Prettier]
** Web site: https://prettier.io/
** Twitter: https://twitter.com/PrettierCode
** GitHub: https://github.com/prettier/prettier
** [https://www.youtube.com/watch?v=hkfBvpEfWdA James Long introducing Prettier (video)]
** [https://www.youtube.com/watch?v=3p6XR2VeHRw Visualization of Prettier Development (video)]
** [https://prettier.io/docs/en/install.html Installing Prettier]
 
* Reviews
** PRs must have a title that explains the fix, links to an Issue #
** PRs must have a full description. If this is UI code, show a screenshot, or explain the fix, talk about how to review it, how to test it, what's not done, what's going to happen in further PRs, etc.
** All PRs must pass CI: eslint, stylelint, unit tests
** Don't let people land code with unrelated commits (e.g., merges with master)
** Ask people to update their master with upstream, and rebase
** Don't let people land code with changes to unrelated lines/files (e.g., package.json, whitespace changes)
** Make sure one PR doesn't undo the work of another (e.g., bad merge, erasing existing code)
** Ask yourself how we'll test every piece of code we take. We need to be able to trust it going forward.
** PRs for us to try reviewing together:
*** [https://github.com/Seneca-CDOT/telescope/pull/102 #102 - Added Extracting of URLs from blog feed function]
*** [https://github.com/Seneca-CDOT/telescope/pull/123 #123 - Fix #74: Validate blog URLs.]
*** [https://github.com/Seneca-CDOT/telescope/pull/136 #136 - Added feed list parser]
*** [https://github.com/Seneca-CDOT/telescope/pull/137 #137 - added pagination to feed for #40]

Navigation menu