Changes

Jump to: navigation, search

User:Egmetcalfe/Dead Code

554 bytes removed, 23:58, 24 March 2010
Bugs/Strangeness
===layout/xul===
 
====void nsBox::CoordNeedsRecalc(PRInt32&)====
 
[http://mxr.mozilla.org/mozilla-central/search?string=CoordNeedsRecalc MXR Search]
 
Code Size: 2
 
This is declared in the header [http://mxr.mozilla.org/mozilla-central/source/layout/xul/base/src/nsBox.h#111 here] as taking an ncoord& parameter however it is defined [http://mxr.mozilla.org/mozilla-central/source/layout/xul/base/src/nsBox.cpp#412 here] as taking PRInt32&. This could be problematic if [http://mxr.mozilla.org/mozilla-central/source/gfx/public/nsCoord.h#74 NS_COORD_IS_FLOAT] is defined.
====void nsBox::CoordNeedsRecalc(PRInt32&)====
Code Size: 41
Same situation, except SetRowHeight is declared in the [http://mxr.mozilla.org/mozilla-central/source/layout/xul/base/src/nsListBoxBodyFrame.h#112 header] as taking a PRInt32 yet the [definition http://mxr.mozilla.org/mozilla-central/source/layout/xul/base/src/nsListBoxBodyFrame.cpp#659definition] lists the parameter as nscoord.
1
edit

Navigation menu