Difference between revisions of "PostgreSQL Adapter Project - Code Review 4 Changes"
Line 113: | Line 113: | ||
|- | |- | ||
|RequestTimeout should take into account non-positive timeouts. | |RequestTimeout should take into account non-positive timeouts. | ||
− | | | + | |values <=0 do not get to requestTimeout |
|- | |- | ||
| The timeout management functionality requestTimeout and releaseTimeout(rename to schedule and cancel) | | The timeout management functionality requestTimeout and releaseTimeout(rename to schedule and cancel) | ||
*should be moved to the cancelation task, as static methods. | *should be moved to the cancelation task, as static methods. | ||
*The timer singleton instance (lazy initialized) should be there as well. | *The timer singleton instance (lazy initialized) should be there as well. | ||
− | | | + | |'''DONE''' |
|- | |- | ||
− | |unwrap | + | |unwrap |
*why is a pooled connection ever used there? | *why is a pooled connection ever used there? | ||
*When could an exception occur? | *When could an exception occur? | ||
*Are we using the correct data source class? | *Are we using the correct data source class? | ||
| | | | ||
+ | - PGXADataSource uses pooled connections<br/> | ||
+ | - When using data load/schema tool<br/> | ||
+ | - Yes, PGXADataSource is the correct data source class | ||
|- | |- | ||
|s_PGXAConnection, s_getQueryExecutor | |s_PGXAConnection, s_getQueryExecutor |
Revision as of 11:48, 14 September 2011
Contents
General
Task | Status |
---|---|
{
} undo the change to ; |
Classes
Table
Task | Status |
---|---|
getQuotedName
|
DONE |
SQLAdapter
Task | Status |
---|---|
setQueryTimeout()
|
DONE |
CancelTask -> StatementCancelationTask;
|
DONE |
SQLSchemaManager
Task | Status |
---|---|
addColumn
|
DONE |
I think the portable flag should not take into account columns that are not added to the table (return null in this case)? | DONE |
The message about ignoring an index has changed
|
Diff is malfunctioning |
There are extensive changes to readSchema?
|
Diff is malfunctioning |
getAlterColumnToken
|
DONE |
isPortable()
This hampers method reusability.). |
DONE |
isWindowsCompatiable -> isWindowsCompatible | DONE |
StatementProxy/PreparedStatementProxy
Task | Status |
---|---|
*Proxy.java -> *Wrapper.java
|
DONE |
PostgreSQLAdapter
Task | Status |
---|---|
MAX_FIELD_PRECISION - is this from the PostgreSQL documentation?
|
DONE |
BIND_BLOB
You already have this value, no need to get it again later on. Use Primitive.createLong() to create the long value.
|
|
BIND_STRING, BIND_BINARY
|
|
RequestTimeout should take into account non-positive timeouts. | values <=0 do not get to requestTimeout |
The timeout management functionality requestTimeout and releaseTimeout(rename to schedule and cancel)
|
DONE |
unwrap
|
- PGXADataSource uses pooled connections |
s_PGXAConnection, s_getQueryExecutor
|
|
appendIdentitySuffix
|
|
appendLiteral
|
|
appendTypeConversion
|
|
indexNameMatches
|
|
isUnicode
|
PostgreSQLPreparedStatementProxy
Task | Status |
---|---|
Provide a class comment | |
Prepend a comment "// inner classes" | |
Use visibility declarators on members ("protected") | |
Fold lines after about 110 chars | |
requestSavepoint
|
PostgreSQLSchemaManager
Task | Status |
---|---|
appendColumnAlteration
|
|
appendLOManagerTrigger
|
|
appendTSIncrement
|
|
getGUIDExpr
|
|
isImplicitConversion
|
|
isValidColumnName
|
|
addColumn
|