Difference between revisions of "PostgreSQL Adapter Project - Code Review 4 Changes"
Line 1: | Line 1: | ||
+ | [[category: NexJ Express PostgreSQL]] | ||
==General== | ==General== | ||
{| border="1" cellpadding="4" cellspacing="2" style="border: 1px solid black;border-collapse:collapse;" | {| border="1" cellpadding="4" cellspacing="2" style="border: 1px solid black;border-collapse:collapse;" |
Revision as of 13:29, 12 September 2011
Contents
General
Task | Status |
---|---|
{
} undo the change to ; |
Classes
Table
Task | Status |
---|---|
getQuotedName
|
SQLAdapter
Task | Status |
---|---|
setQueryTimeout()
|
|
CancelTask -> StatementCancelationTask;
|
SQLSchemaManager
Task | Status |
---|---|
addColumn
|
|
Move rs argument to the last position | |
I think the portable flag should not take into account columns that are not added to the table (return null in this case)? | |
The message about ignoring an index has changed
|
|
There are extensive changes to readSchema?
|
|
getAlterColumnToken
|
|
isPortable()
This hampers method reusability.). |
|
isWindowsCompatiable -> isWindowsCompatible |
StatementProxy/PreparedStatementProxy
Task | Status |
---|---|
*Proxy.java -> *Wrapper.java
|
PostgreSQLAdapter
Task | Status |
---|---|
MAX_FIELD_PRECISION - is this from the PostgreSQL documentation?
|
|
MAX_LO_SIZE - Remove "~~" from the comment. This is 2GB-1. | |
BIND_BLOB
You already have this value, no need to get it again later on. Use Primitive.createLong() to create the long value.
|
|
BIND_STRING, BIND_BINARY
|
|
RequestTimeout should take into account non-positive timeouts. | |
The timeout management functionality requestTimeout and releaseTimeout(rename to schedule and cancel)
|
|
unwrap
|
|
s_PGXAConnection, s_getQueryExecutor
|
|
appendIdentitySuffix
|
|
appendLiteral
|
|
appendTypeConversion
|
|
indexNameMatches
|
|
isUnicode
|
PostgreSQLPreparedStatementProxy
Task | Status |
---|---|
Provide a class comment | |
Prepend a comment "// inner classes" | |
Use visibility declarators on members ("protected") | |
Fold lines after about 110 chars | |
requestSavepoint
|
PostgreSQLSchemaManager
Task | Status |
---|---|
appendColumnAlteration
|
|
appendLOManagerTrigger
|
|
appendTSIncrement
|
|
getGUIDExpr
|
|
isImplicitConversion
|
|
isValidColumnName
|
|
addColumn
|