1
edit
Changes
→PostgreSQLAdapter
*If an error occurs, lo will not be closed. Please fix this.
* setAutoCommit - why is this modified at all? We cannot simply change the autocommit flag on a connection.
|''DONE'''*Remove BIND_BLOB
|-
|BIND_STRING, BIND_BINARY
*Are we using the correct data source class?
|
- PGXADataSource uses is the one that gives pooled connections<br/>
- When using data load/schema tool<br/>
- Yes, PGXADataSource is the correct data source class
*what is the purpose of the conditional logic involving these?
|
-s_PGXAConnection used to ensure that reflected methods and properties loaded successfully<br/>
-s_getQueryExecutor used to ensure that unwrapped connection is a PGConnection
|-
|appendIdentitySuffix
*Add a space after ";" for readability
|'''DONE'''
|-
|appendLiteral
*TIMESTAMP_ORDINAL - this should be in UTC, I think that simply converting the timestamp to a string might not do it.
*Try to see if using Primitive.toString() will provide the right format.
|'''DONE'''*used StringUtil.appendUTC
|-
|appendTypeConversion
*TIMESTAMP_ORDINAL - please verify that this actually formats/parses UTC timestamps.
|'''DONE'''*modified postgresql setup scripts to set timezone to UTC*changed to use date_part('epoch', timestamp)
|-
|indexNameMatches
*Spaces around commas are needed. Wrap the line after about 110 chars.
|'''DONE'''
|-
|isUnicode<br/>
*Use lower case SQL keywords
*Use bind variables - this is what makes prepared statements cacheable by the DB
*catch(SQLException e) space before (
*Do not repackage the SQLException as a runtime exception - the method already allows throwing an SQLException
|'''DONE'''
|}