Difference between revisions of "Mouse Lock API Test Tracker"

From CDOT Wiki
Jump to: navigation, search
(Mouse Lock API Test)
(Test [as of 31st January, 2012])
Line 124: Line 124:
 
| -
 
| -
 
|  
 
|  
 
 
* '''FIXED'''  
 
* '''FIXED'''  
 
* '''UPLOADED'''
 
* '''UPLOADED'''
Line 140: Line 139:
 
| -
 
| -
 
|  
 
|  
 
 
* '''FIXED'''  
 
* '''FIXED'''  
 
* '''UPLOADED'''
 
* '''UPLOADED'''
 
| Merged
 
| Merged
 
| X
 
| X
|  
+
| Fixed formatting issues
* No
+
 
 
|-
 
|-
 
| 8
 
| 8
Line 157: Line 155:
 
| -
 
| -
 
|  
 
|  
|
+
* '''FIXED'''
| '''FIXED'''
+
* '''UPLOADED'''
|  
+
| Merged
 
| X
 
| X
|
+
| Re-formatted for consistencies
 
|-
 
|-
 
| 9
 
| 9
Line 171: Line 169:
 
|
 
|
 
| Doesn't seem like it can be done via mochitest
 
| Doesn't seem like it can be done via mochitest
|
 
|
 
 
| '''REMOVED'''
 
| '''REMOVED'''
 
|
 
|
Line 186: Line 182:
 
| X
 
| X
 
| -
 
| -
 +
|
 +
 +
* '''FIXED'''
 +
* '''UPLOADED'''
 +
 +
| Merged
 +
| X
 
|  
 
|  
|
+
* Removed some test that were repeating. Otherwise, it works
| '''FIXED''' 
+
* Renamed to '''file_pointerLockLost.html''' to adhere to specification
|
 
| X
 
| Removed some test that were repeating. Otherwise, it works
 
 
|-
 
|-
 
| 11
 
| 11
Line 201: Line 201:
 
| X
 
| X
 
| -
 
| -
|
+
| '''Tentative Fix'''   
|
+
| Merged
| '''Fixing'''   
 
|  
 
 
| X
 
| X
|
+
| This test have multiple parts
 +
* checks for mozMovementX and mozMovementY exists and their values before and after lock - FIXED
 +
* checks that repeated movement does not exceed the width/height of the screen - FAILED TO RUN PROPERLY (REMOVED TENTATIVELY)
 
|-
 
|-
 
| 12
 
| 12
 
| file_targetOutOfFocus.html
 
| file_targetOutOfFocus.html
| rhung
+
| <s>rhung</s>Anachid
 
| X
 
| X
 
| X
 
| X
Line 217: Line 217:
 
| -
 
| -
 
|  
 
|  
 +
* '''FIXED'''
 +
* '''UPLOADED'''
 +
| Merged
 +
| X
 
|  
 
|  
| '''FIXED''' 
+
* Minor changes, mostly styling.
|
+
* Minor timing issues detected, fixed by Anachid
| X
 
| Minor changes, mostly styling.
 
 
|-
 
|-
 
| 13
 
| 13
Line 232: Line 234:
 
| -
 
| -
 
|  
 
|  
|
+
* '''FIXED & RENAMED'''   
| '''FIXED & RENAMED'''   
+
* '''UPLOADED'''
|  
+
| Merged
 
| X
 
| X
 
| Updated to test_MozPointerLock.html
 
| Updated to test_MozPointerLock.html
Line 245: Line 247:
 
| X
 
| X
 
| X
 
| X
| Leak issue might be platform specific.
+
| <s>Leak issue might be platform specific.</s>
 +
 
 +
no longer a platform issue as it happens on linux as well - Anachid
 +
| '''FIXING''' 
 
|  
 
|  
 +
| X
 
|  
 
|  
| '''FIXED?'''
+
* "mouseover", "mouseout", "mouseenter", "mouseleave" have been moved to another: file_cursorPosEvents.html
|  
+
|-
 +
| 15
 +
| file_cursorPosEvents.html
 +
| rhung
 +
| X
 +
| X
 +
| X
 +
| X
 +
| -
 +
|
 +
* '''FIXED'''  
 +
* '''UPLOADED'''
 +
| Merged
 
| X
 
| X
| Works without chance of hanging or random success and failures.
+
| stripped out from file_MouseEvents.html
 
|-
 
|-
| 15
+
| 16
 
| file_limitlessScroll.html
 
| file_limitlessScroll.html
 
| rhung
 
| rhung
Line 261: Line 279:
 
|
 
|
 
|
 
|
|
 
|
 
 
| '''MERGED WITH file_movementXY'''   
 
| '''MERGED WITH file_movementXY'''   
|
 
 
|
 
|
 
|
 
|
 +
| See file_movementXY.html for comment
 
|-
 
|-
 
| 16
 
| 16
 
| file_defaultUnlock.html
 
| file_defaultUnlock.html
| rhung
+
| <s>rhung</s>Anachid
|
+
| X
|
+
| X
|
+
| X
|
+
| X
|
+
| read comments
|
 
|
 
| '''FIXED''' 
 
 
|  
 
|  
 +
* '''FIXED'''
 +
* '''UPLOADED'''
 +
| Merged
 
| X
 
| X
|
+
| Changed ownership to Anachid -
 +
* Old version was unable to synthesize the key events and is crashing
 +
* Re done the entire file to ensure the events are executed properly
 +
 
 
|-
 
|-
 
| 17
 
| 17
Line 291: Line 310:
 
|
 
|
 
|
 
|
|
 
|
 
| '''FIXED''' 
 
 
|
 
|
 +
 +
* '''FIXED'''
 +
* '''UPLOADED'''
 +
| Merged
 
| X
 
| X
|
+
| Anachid -
 +
* Changed for inconsistent format
 +
* Small minor bug fix
 
|-
 
|-
 
| 18
 
| 18
 
| file_constantXY.html
 
| file_constantXY.html
 
| rhung
 
| rhung
|
+
| X
|
+
| X
|
+
| X
|
+
| X
|
+
| X
 
|  
 
|  
|
+
* '''FIXED'''
| '''FIXING'''
+
* '''UPLOADED'''
|
+
| Merged
 
| X
 
| X
 
| Needs proper error messages, perhaps formatting issues. Test runs fine though.
 
| Needs proper error messages, perhaps formatting issues. Test runs fine though.

Revision as of 11:27, 31 January 2012

Mouse Lock API Test

The Mouse Lock Test had changed considerably since the start of the MouseLock Implementation from the Fall 2011 Semester. As such, a new page is required to track the test properly. A link to the old test tracker is available here. The tests are coded by three person:


Test [as of 31st January, 2012]

This is a new list of test. The following tests will need to confirm to the new prefixes in accordance to Patchv3 of Bug 633602. Please add your name beside each test(s) you are assessing/reviewing/fixing. Once the cause for rejection is clear, indicate it by placing an X in any of the columns and optionally filling out the comments column. Indicate the action taken to resolve the issue in the action taken column. Example actions include:

  1. DELETED
  2. FIXED

Other actions are also acceptable where appropriate. Once fixed, please pull request to Steven's (Anachid's mouselock) branch and indicate that you've done so in the pull requested column. Ensure that you add [POST-SUBMIT] to the name of your pull request.

Num Name Primary Reviewer Timing issues? Needs Harness? Needs focus? Formatting issues? Other? (Indicate in comments) Action Taken Pull requested? Updated with Patchv3 Comments
Add my repo as a "remote" and ensure you have actually tested your test before sending a pull request
1 test_FullScreenHarness.html Anachid X (no action) X (no action) X (no action) X (no action) -
  • FIXED
  • UPLOADED
Merged X No issues
2 file_DOMtree.html Anachid X (fixed) X (fixed) X (fixed) X (no action) -
  • FIXED
  • UPLOADED
Merged X No issues
3 file_nestedFullScreen.html Anachid X (fixed) X (fixed) X (fixed) X (no action) -
  • FIXED
  • UPLOADED
Merged X Had timing issues
4 file_differentDOM.html Anachid X (no action) X (no action) X (no action) X (no action) -
  • FIXED
  • UPLOADED
Merged X Removed style "display: none" as this causes a crash
5 file_fullscreen.html Anachid X X X X -
  • FIXED
  • UPLOADED
Merged X Test needs to completely re-done. Cases like
  • ok(false, "Mouse locked without fullscreen mode"); will always fail!
  • Flow of the test will causes scope problems.
  • Currently fixing.
6 file_doubleLockCallBack.html Anachid X X X X -
  • FIXED
  • UPLOADED
Merged X Re-formatted for consistencies
7 file_unlockOnUnload.html Anachid X X X X -
  • FIXED
  • UPLOADED
Merged X Fixed formatting issues
8 file_exitMouseLockOnLoseFocus.html Anachid X X X X -
  • FIXED
  • UPLOADED
Merged X Re-formatted for consistencies
9 test_mousePos.html rhung Doesn't seem like it can be done via mochitest REMOVED As mentioned in the previous comments, synthesizeMouse cannot be moved beyond the browser. It might need to be a litmus test.
10 file_mouselocklost.html Anachid X X X X -
  • FIXED
  • UPLOADED
Merged X
  • Removed some test that were repeating. Otherwise, it works
  • Renamed to file_pointerLockLost.html to adhere to specification
11 file_movementXY.html rhung X X X X - Tentative Fix Merged X This test have multiple parts
  • checks for mozMovementX and mozMovementY exists and their values before and after lock - FIXED
  • checks that repeated movement does not exceed the width/height of the screen - FAILED TO RUN PROPERLY (REMOVED TENTATIVELY)
12 file_targetOutOfFocus.html rhungAnachid X X X X (fixed) -
  • FIXED
  • UPLOADED
Merged X
  • Minor changes, mostly styling.
  • Minor timing issues detected, fixed by Anachid
13 test_mouseLockable.html rhung X X X X -
  • FIXED & RENAMED
  • UPLOADED
Merged X Updated to test_MozPointerLock.html
14 file_MouseEvents.html rhung X X X X Leak issue might be platform specific.

no longer a platform issue as it happens on linux as well - Anachid

FIXING X
  • "mouseover", "mouseout", "mouseenter", "mouseleave" have been moved to another: file_cursorPosEvents.html
15 file_cursorPosEvents.html rhung X X X X -
  • FIXED
  • UPLOADED
Merged X stripped out from file_MouseEvents.html
16 file_limitlessScroll.html rhung MERGED WITH file_movementXY See file_movementXY.html for comment
16 file_defaultUnlock.html rhungAnachid X X X X read comments
  • FIXED
  • UPLOADED
Merged X Changed ownership to Anachid -
  • Old version was unable to synthesize the key events and is crashing
  • Re done the entire file to ensure the events are executed properly
17 file_userPref.html rhung
  • FIXED
  • UPLOADED
Merged X Anachid -
  • Changed for inconsistent format
  • Small minor bug fix
18 file_constantXY.html rhung X X X X X
  • FIXED
  • UPLOADED
Merged X Needs proper error messages, perhaps formatting issues. Test runs fine though.


New Tests (not sure if it will work on mochitest, and the test will possibly fail as dave is working on this patch)

  1. When there is a parent element with multiple child element, have a test to check that all mouse events fired inside the child element are suppressed and is captured by the parent element. (this may also include the scenario where there is an iframe in the parent element)
  2. A Test to check that repeated move of the mouse to a certain direction that will exceed the screen size does not break the mouselock (this may conflict with file_movementXY.html and we may need to add more test cases)