LukasBlakkTBBugFixLab

From CDOT Wiki
Revision as of 21:28, 8 November 2007 by Backinblakk (talk | contribs) (Fixing the problem)
Jump to: navigation, search

This the page where I will document my results of doing the Thunderbird_Bug_Fix_Lab

Filing a bug

First I had to create a bug over on landfill - explaining the issue

The gist is that anything that has characters@...Someothercharacters turns into a mailto: link in Thunderbird and this was annoying Dave so the whole class jumped to fix it.

Fixing the problem

Dowloaded and built a copy of Thunderbird's trunk on my MacBook and then navigated over to mozTXTToHTMLConv.cpp in order to alter some code which checks for a '.' after the @ symbol but does not also check that there is not a ".." in that string.

This is a one-line fix but I was having some trouble getting my code changes to show up. Funny story, this happened to me in class too and both times it was because I forgot a ) in the code.

Creating a patch

Requesting Review

Results of Review