1
edit
Changes
→Review Issues
* Finish tests, updated to changes above.
* <s>Update patch to trunk</s> - humph
* Figure out why DOMMouseScroll events aren't being retargeted to the locked element
* Look into roc's suggestion from bug 722449 comment 8, namely, using getBoundingClientRect vs. GetPrimaryFrame()
* Maybe use nsStubMutationObserver instead of nsIMutationObserver?
* Extensions to the Document Interface. Add pointerLockElement attribute and exitPointerLock method - diogogmt
* Update Element interface to have requestPointerLock - diogogmt
* <s>Dispatch pointerlockchange or pointerlockerror events instead of firing a callback when pointer gets locked</s> - diogogmt
* Update mochitests to use new pointerlock API
* Add expect number of tests to mochitests
* Update patch to trunk
===Tests===
|
|
| '''Nothing necessaryFixing'''
|
| X
| Worked as is.
|-
| 12
|-
| 13
| file_mouseLockabletest_mouseLockable.html
| rhung
| X
|
|
| '''FIXED& RENAMED'''
|
| X
| Just needed an update Updated to the new patchtest_MozPointerLock.html
|-
| 14
|
|
| Logic needs to be redone to use screenX and screenY, can| | | 't assume always in the middle just because we have mouse lock''MERGED WITH file_movementXY''' | |||-| 16| file_defaultUnlock.html| rhung|||||| | | '''FIXED'''
|
| X
|
|-
| 17
| file_userPref.html
| rhung
|
|
|
|
|
|
|
| '''FIXED'''
|
| X
|
|-
| 18| file_constantXY.html| rhung|||||| | | '''FIXING''' || X| Needs proper error messages, perhaps formatting issues. Test runs fine though.|-
|}
