667
edits
Changes
no edit summary
* [[DPS909 & OSD600 Winter 2017 - Lab 5 | Lab 5]]
==Week 7==
* Continuing with https://github.com/mozilla/thimble.mozilla.org/issues/1696
** https://github.com/juliandescottes/piskel
** https://github.com/juliandescottes/piskel-embed
* Issues:
** How to combine this into an extension?
** How to trigger things to load when you open a file?
** How to deal with save, open events with Bracket's filesystem?
* [[DPS909 & OSD600 Winter 2017 - Lab 6 | Lab 6]]
==Week 8==
* Code Review
** A change to the project is done by a contributor '''and''' a reviewer (and maybe more than one of each).
** No one is on their own doing work. No one is solely to blame for what happens next, good or bad.
** Automated vs. Manual code review
*** Linters (eslint, standard, csslint, etc)
*** Build systems, task runners (grunt, gulp, etc)
*** Travis CI
** Code review as scaling factor: enabling contributions
** Code review has nothing to do with how good you are at programming, isn't a value statement about you.
* Questions
** Do you need review on a one line change? A one word change? Why?
** What are the types of changes/results that you need to review? What is the process like?
** How does code review differ from pair programming, or working directly with a partner in the class/office?
* GitHub Code Reviews
** [https://help.github.com/articles/requesting-a-pull-request-review/ Asking for a review on a PR]
** [https://help.github.com/articles/about-pull-request-reviews/ PR Reviews]
* Let's do some reviews
** https://github.com/mozilla/thimble.mozilla.org/pulls
** https://github.com/mozilla/brackets/pulls
* [[DPS909 & OSD600 Winter 2017 Release 0.2 | 0.2 Release (Due Tues Mar 7)]]
** What worked?
** What didn't?
** What do you need to do differently for 0.3, 0.4?
** What did you learn doing this release?
** What still confuses you, or are you finding hard?
==Weeks 9, 10, 11, 12==
* More on Code Review
** How to create a good PR?
** https://github.com/mozilla/thimble.mozilla.org/pull/1559 is a **great** example of a good PR.
** This isn't a "beginner" problem, everyone struggles with it (cf. https://groups.google.com/forum/#!topic/mozilla.dev.platform/3ig8TZ-0rN8)
** Tips:
*** Name your branches with issue numbers, or describe your fix (e.g., <code>issue-123, fix-sidebar-styling</code>)
*** If you are fixing an issue, mention the issue number in your PR subject or commit message: <code>Fix #123: Fixing styling on sidebar to not overlap title</code>). GitHub will automatically close issues that are mentioned like this when the PR is merged.
*** Don't just use the issue number. Make sure you also include text to describe your fix.
*** Commit messages don't have to be 1-line long! You can write a long description of what you did, changes that are coming as a result, advice for devs following your patch, etc.
*** If your code has some visible impact on the app, create screenshots or a screencast animated gif and include it in the PR.
*** Discuss what your change does, what it's fixing, and how you solved it.
*** Tell the reviewer how to test your change, what to pay special attention to when reviewing, and give any other guidance.
* Learning JavaScript In Depth
** Look at code in Thimble (browser and node) and Brackets
** Understand node.js programming
** Complex ideas in JS:
*** Object Literals and JSON
*** Constructor Functions and <code>new</code>
*** Prototypical Inheritance
*** The many meanings of <code>this</code>
*** [http://bonsaiden.github.io/JavaScript-Garden/#function Anonymous Functions (lambdas)]
*** [http://underscorejs.org/docs/underscore.html Self-executing anonymous functions]
*** [https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array Functional programming with Arrays], [https://github.com/adobe/brackets/blob/6affa7907fdc820f7b9083bc0ff7c9fb87fb3e57/src/language/HTMLInstrumentation.js#L93-L123 example]
*** [https://github.com/adobe/brackets/blob/ae17456a596965a1247b79ddb82c6e1518bc6e5e/src/utils/UrlParams.js Constructor functions and the prototype], [https://github.com/mozillafordevelopment/webmaker-app/blob/bfa6377bf49d14c16868dd3a4ae7b8f9fbcfcaea/lib/model.js another example]
*** [https://github.com/adobe/brackets/blob/791bcc436155cbd8e8e73429af4ca3fde0881703/src/utils/Compatibility.js Extending native prototypes]
*** [https://github.com/filerjs/filer/blob/develop/src/errors.js Dynamic property access]
* [[DPS909 & OSD600 Winter 2017 - Lab 7 | Lab 7]]
* [[DPS909 & OSD600 Winter 2017 - Lab 8 | Lab 8]]
* [[DPS909 & OSD600 Winter 2017 - Lab 9 | Lab 9]]
* [[DPS909 & OSD600 Winter 2017 Release 0.3 | 0.3 Release]]
* [[DPS909 & OSD600 Winter 2017 Release 0.4 | 0.4 Release]]
<!--