Difference between revisions of "Cue Times"

From CDOT Wiki
Jump to: navigation, search
(Vince)
(Vince: added peer review column)
Line 113: Line 113:
 
|class="header"|'''Creation Note'''
 
|class="header"|'''Creation Note'''
 
|class="header"|'''Comments'''
 
|class="header"|'''Comments'''
 +
|class="header"|'''Peer Review'''
 
|-
 
|-
 
|bad01.vtt
 
|bad01.vtt
Line 119: Line 120:
 
|End timestamp must be greater than start timestamp
 
|End timestamp must be greater than start timestamp
 
|
 
|
 +
|
 +
 
|
 
|
 
|-
 
|-
Line 126: Line 129:
 
|End timestamp must be greater than start timestamp
 
|End timestamp must be greater than start timestamp
 
|
 
|
 +
|
 +
 
|
 
|
 
|-
 
|-
Line 134: Line 139:
 
|
 
|
 
|Took out the -->
 
|Took out the -->
 +
 +
|
 
|-
 
|-
 
|bad04.vtt
 
|bad04.vtt
Line 140: Line 147:
 
|Milliseconds must be 3 digits
 
|Milliseconds must be 3 digits
 
|
 
|
 +
|
 +
 
|
 
|
 
|-
 
|-
Line 147: Line 156:
 
|Seconds should be 2 digits
 
|Seconds should be 2 digits
 
|
 
|
 +
|
 +
 
|
 
|
 
|-
 
|-
Line 154: Line 165:
 
|Minutes should be 2 digits
 
|Minutes should be 2 digits
 
|
 
|
 +
|
 +
 
|
 
|
 
|-
 
|-
 
'''TODO:''' Break hour, see if days work, create multiple cue times that don't make sense (first cue at 2 minutes, second at 1 minute)
 
'''TODO:''' Break hour, see if days work, create multiple cue times that don't make sense (first cue at 2 minutes, second at 1 minute)

Revision as of 22:13, 25 September 2012

Group Members

  • Vince Lee
  • Thevakaran Virutthasalam
  • Dale Karp

Test Ideas

  • Syntax
  • Single cue tests
    • Times out of order
  • Multiple cue tests
    • Nested cues
    • Overlapping cues
    • Cue times out of order

Testing Procedure

Writing Tests

  1. Check if the test you have in mind exists already in the wiki
  2. If not, write your test case file
  3. When you finish writing, document the test case in the wiki ASAP so you don't forget!
  4. Commit your test case to the github repo

Peer Review

  1. Review someone else's test case
  2. Sign off in the 'Peer Review' column of the table with your name so that we know it's been looked at (TO DO: Create Peer Review column in tables)

Cue Time Syntax Rules

  1. A WebVTT timestamp representing the start time offset of the cue. The time represented by this WebVTT timestamp must be greater than or equal to the start time offsets of all previous cues in the file.
  2. One or more U+0020 SPACE characters or U+0009 CHARACTER TABULATION (tab) characters.
  3. The string "-->" (U+002D HYPHEN-MINUS, U+002D HYPHEN-MINUS, U+003E GREATER-THAN SIGN).
  4. One or more U+0020 SPACE characters or U+0009 CHARACTER TABULATION (tab) characters.
  5. A WebVTT timestamp representing the end time offset of the cue. The time represented by this WebVTT timestamp must be greater than the start time offset of the cue.

Tests

Dale

URL to git repo with tests: https://github.com/daliuss/webvtt/tree/cueTimeTests/test/spec

Filename Description Should Pass / Fail? Reasoning Creation Note Comments
cuetime_bareminimum.vtt Bare minimum file that passes (no cue content) Pass Conforms to spec ST2
cuetime_bareminimum_content.vtt Bare minimum file that passes (cue content) Pass Conforms to spec ST2

Vince

I'm gonna remake the table using markdown. Hitting <td></td> is tedious

TODO: Break hour, see if days work, create multiple cue times that don't make sense (first cue at 2 minutes, second at 1 minute)
Filename Description Should Pass / Fail? Reasoning Creation Note Comments Peer Review
bad01.vtt 00:00.000 --> 00:00.000 Fail End timestamp must be greater than start timestamp
bad02.vtt 00:00.001 --> 00:00.000 Fail End timestamp must be greater than start timestamp
bad03.vtt 00:00.000 00:00.001 Fail Timestamp separator not found Took out the -->
bad04.vtt 00:00.0000 --> 00:00.001 Fail Milliseconds must be 3 digits
bad05.vtt 00:000.000 --> 00:00.001 Fail Seconds should be 2 digits
bad06.vtt 000:00.000 --> 00:00.001 Fail Minutes should be 2 digits